| From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Subject: | Re: Add pg_get_injection_points() for information of injection points |
| Date: | 2025-07-03 06:44:55 |
| Message-ID: | CAH2L28sePmh4PET+AfWDicoV=N7w2gGnSAMsAJjiMD23NGatNg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
#include "miscadmin.h"
+#include "nodes/execnodes.h"
#include "nodes/pg_list.h"
#include "nodes/value.h"
Do we need to include this? I did not see any compilation error when I
removed this.
> Now for the second part with the SRF making the injection point
> information available at SQL level. The point about adding the new
> function in the core engine has been sticky, and I'm coming down to
> the conclusion that I'd still want to make this stuff backpatchable if
> need be in the future. So let's just add a new function in the test
> module injection_points and call it a day.
>
>
Do you plan to document this function anywhere where it would be more
visible to those
who might want to use it in their tests?
Thank you,
Rahila Syed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2025-07-03 06:54:50 | Re: stats.sql might fail due to shared buffers also used by parallel tests |
| Previous Message | Shinya Kato | 2025-07-03 06:40:07 | Re: Extend COPY FROM with HEADER <integer> to skip multiple lines |