| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Addition of %b/backend_type in log_line_prefix of TAP test logs |
| Date: | 2025-06-20 07:20:21 |
| Message-ID: | aFULtdii801e9cfx@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 24, 2025 at 09:09:36AM +0900, Michael Paquier wrote:
> On Fri, May 23, 2025 at 11:56:59PM +0900, Fujii Masao wrote:
>> On 2025/05/22 8:58, Tom Lane wrote:
>>> I'd vote for standardizing on pg_regress.c's spelling, as that's got
>>> the most usage history behind it. I'm unexcited about bloating the
>>> logs with [%v:%x] --- that's data I've very seldom needed.
>>
>> +1
Coming back to this thread as v19 is going to open up rather soon, the
suggestion from Tom seems to be the consensus reached, which is to use
the same value of log_line_prefix in the CI and the TAP as in
pg_regress.c. Attached is a patch to do so, that I'd like to apply on
HEAD once v19 opens up.
If anybody would prefer a backpatch or if anybody has any comments,
please feel free.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| tap-logs-backend_type-v2.patch | text/x-diff | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-06-20 07:22:11 | Re: Conflict detection for update_deleted in logical replication |
| Previous Message | Bertrand Drouvot | 2025-06-20 06:45:01 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |