| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, David Steele <david(at)pgbackrest(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Regression in statement locations |
| Date: | 2025-05-20 08:47:32 |
| Message-ID: | aCxBpHYiYWlEt5ql@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 20, 2025 at 09:58:04AM +0200, Anthonin Bonnefoy wrote:
> Looking at the tests, there are 2 additionals empty DO blocks:
> +DO $$
> +DECLARE BEGIN
> +END $$;
>
> What's the point of those? They won't be visible in the output since
> we have 'toplevel IS FALSE' in the pg_stat_statements calls and they
> don't fit the "DO block --- multiple inner queries with separators".
That's a copy-pasto. Will remove.
> Other than that, the patch looks good.
Thanks for the review, Anthonin and Jian.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-05-20 08:52:53 | Re: Log connection establishment timings |
| Previous Message | Aleksander Alekseev | 2025-05-20 08:29:30 | Re: Should we optimize the `ORDER BY random() LIMIT x` case? |