Re: PG versus libxml2 2.12.x

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PG versus libxml2 2.12.x
Date: 2024-01-29 14:56:12
Message-ID: a9e2f184-6267-4f74-9922-9211d78f6f9a@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27.01.24 20:04, Tom Lane wrote:
> Buildfarm member caiman has been failing build for a couple weeks now.
> The reason turns out to be that recent libxml2 has decided to throw
> a "const" into the signature required for custom error handlers.
> (API compatibility? What's that?)
>
> I don't mind adopting the "const" --- it's a good idea in isolation.
> The trouble is in fixing our code to work with both old and new
> libxml2 versions. We could thrash around with a configure test or
> something, but I think the most expedient answer is just to insert
> some explicit casts, as shown in the attached. It's possible though
> that some compilers will throw a cast-away-const warning. I'm
> not seeing any, but ...

In PL/Tcl, we used to have these CONST84 and CONST86 things, for similar
reasons. Maybe that would be another approach.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-01-29 14:59:04 Re: scalability bottlenecks with (many) partitions (and more)
Previous Message Ronan Dunklau 2024-01-29 14:15:25 Re: scalability bottlenecks with (many) partitions (and more)