Re: PG versus libxml2 2.12.x

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PG versus libxml2 2.12.x
Date: 2024-01-29 15:19:47
Message-ID: 1784723.1706541587@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 27.01.24 20:04, Tom Lane wrote:
>> I don't mind adopting the "const" --- it's a good idea in isolation.
>> The trouble is in fixing our code to work with both old and new
>> libxml2 versions. We could thrash around with a configure test or
>> something, but I think the most expedient answer is just to insert
>> some explicit casts, as shown in the attached. It's possible though
>> that some compilers will throw a cast-away-const warning. I'm
>> not seeing any, but ...

> In PL/Tcl, we used to have these CONST84 and CONST86 things, for similar
> reasons. Maybe that would be another approach.

Yeah, if the simple cast approach turns out to create warnings,
we'll have to fall back on using actually different declarations.
I'm hoping to not have to go there.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-01-29 15:23:38 Re: Should we remove -Wdeclaration-after-statement?
Previous Message Alvaro Herrera 2024-01-29 15:04:33 Re: separating use of SerialSLRULock