Re: relcache sometimes initially ignores has_generated_stored

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: relcache sometimes initially ignores has_generated_stored
Date: 2020-02-06 20:29:58
Message-ID: a9615ad4-9063-4089-e740-d74b118e984c@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-01-15 19:11, Andres Freund wrote:
> /*
> * Set up constraint/default info
> */
> if (has_not_null || ndef > 0 ||
> attrmiss || relation->rd_rel->relchecks)
> test, i.e. there are no defaults.

> It does still strike me as not great that we can get a different
> relcache entry, even if transient, depending on whether there are other
> reasons to create a TupleConstr. Say a NOT NULL column.
>
> I'm inclined to think we should just also check has_generated_stored in
> the if quoted above?

Fixed that way.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-02-06 20:30:02 Re: Internal key management system
Previous Message Robert Haas 2020-02-06 19:59:09 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?