Re: relcache sometimes initially ignores has_generated_stored

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: relcache sometimes initially ignores has_generated_stored
Date: 2020-02-06 20:40:22
Message-ID: 20200206204022.lkjrfroxoljxitzo@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-02-06 21:29:58 +0100, Peter Eisentraut wrote:
> On 2020-01-15 19:11, Andres Freund wrote:
> > /*
> > * Set up constraint/default info
> > */
> > if (has_not_null || ndef > 0 ||
> > attrmiss || relation->rd_rel->relchecks)
> > test, i.e. there are no defaults.
>
> > It does still strike me as not great that we can get a different
> > relcache entry, even if transient, depending on whether there are other
> > reasons to create a TupleConstr. Say a NOT NULL column.
> >
> > I'm inclined to think we should just also check has_generated_stored in
> > the if quoted above?
>
> Fixed that way.

Thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Cary Huang 2020-02-06 21:36:58 Re: Internal key management system
Previous Message Robert Haas 2020-02-06 20:30:02 Re: Internal key management system