Re: Fixup some appendStringInfo and appendPQExpBuffer calls

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date: 2021-06-03 13:03:14
Message-ID: a8ed7319-bbee-9c77-d3fc-e2e352ba6146@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03.06.21 06:17, Tom Lane wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
>> There are quite a few other places in that file that should be using
>> DatumGetCString() instead of DatumGetPointer().
>> Should we fix those too for PG14?
>
> +1. I'm surprised we are not getting compiler warnings.

Well, DatumGetPointer() returns Pointer, and Pointer is char *.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-06-03 13:08:45 Re: parent foreign tables and row marks
Previous Message Peter Eisentraut 2021-06-03 13:01:05 Re: improve installation short version