Re: Fixup some appendStringInfo and appendPQExpBuffer calls

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date: 2021-06-03 04:17:06
Message-ID: 246592.1622693826@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> There are quite a few other places in that file that should be using
> DatumGetCString() instead of DatumGetPointer().
> Should we fix those too for PG14?

+1. I'm surprised we are not getting compiler warnings.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-06-03 04:39:06 Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Previous Message vignesh C 2021-06-03 04:08:37 Re: locking [user] catalog tables vs 2pc vs logical rep