Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: 2021-07-13 04:17:01
Message-ID: a8d24099-6570-c18a-ae16-bcd221a5eada@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.07.21 01:46, Tom Lane wrote:
> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
> as 1 or 0, but some of the entries in msvc/Solution.pm show
> such symbols as "undef" instead. Shouldn't we fix it as
> per attached? This is probably only cosmetic at the moment,
> but it could bite us someday if someone wrote a complex
> conditional using one of these symbols.

Yes, I think that is correct.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-07-13 04:25:06 Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Previous Message r.takahashi_2@fujitsu.com 2021-07-13 04:13:58 RE: Transactions involving multiple postgres foreign servers, take 2