| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Bogus HAVE_DECL_FOO entries in msvc/Solution.pm |
| Date: | 2021-07-12 23:46:32 |
| Message-ID: | 3185430.1626133592@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
as 1 or 0, but some of the entries in msvc/Solution.pm show
such symbols as "undef" instead. Shouldn't we fix it as
per attached? This is probably only cosmetic at the moment,
but it could bite us someday if someone wrote a complex
conditional using one of these symbols.
These apparently-bogus values date to Peter's 8f4fb4c64,
which created that table; but AFAICS it was just faithfully
emulating the previous confused state of affairs.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-bogus-HAVE_DECL-values.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-07-13 00:01:15 | Re: proposal - psql - use pager for \watch command |
| Previous Message | Tom Lane | 2021-07-12 23:16:35 | Re: proposal: possibility to read dumped table's name from file |