| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Comment for UserMappingPasswordRequired in contrib/postgres_fdw |
| Date: | 2026-02-22 23:01:31 |
| Message-ID: | a81dbd27-2738-47d6-b838-9a24678a6c26@proxel.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/22/26 12:10 PM, Etsuro Fujita wrote:
>> /*
>> * Checks the value of password_required, defaults to true
>> * if not defined. The mapping has been pre-validated.
>> */
>
> I like your wording. I am not a native speaker either, though. This
> would be nitpicking, but I think it is better to clearly mention what
> the function returns. How about modifying it a bit, like this?
>
> /*
> * Check and return the value of password_required, if defined; otherwise,
> * return true, which is the default value of it. The mapping has been
> * pre-validated.
> */
No strong opinion. I would be fine with either. I do not think saying
that it returns is necessary since you can see that from the function
definition but it does not really harm either.
--
Andreas Karlsson
Percona
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-02-23 01:15:09 | RE: Improve docs syntax checking and enable it in the meson build |
| Previous Message | Yasir | 2026-02-22 21:30:27 | Re: Regression failures after changing PostgreSQL blocksize |