Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl

Hello Nazir and Ayush,

04.09.2026 11:40, Nazir Bilal Yavuz wrote:
>>> I'm not sure about the autovacuum fix -- I've found that I tried the same
>>> targeted autovacuum = false as Melanie proposed back then ([1]) and the
>>> test still failed. Please let me recheck carefully if it's still an issue.
>>>
>>> Regarding v1-0001, I've tested it with the repro.patch applied and
>>> confirmed it works. Thank you!
>>>
>>> [1]https://www.postgresql.org/message-id/714729ea-f536-0faf-353b-cbd5c8f241ea%40gmail.com
>> Thanks for testing and confirming 0001.
> I confirm that the bug is reproducible with repro.patch and 0001 fixes it.
>
>> One detail I noticed in [1] is that the posted change sets
>> autovacuum_enabled=false on the initial table. That table is later dropped
>> and recreated for the recovery deadlock test, so the reloption does not
>> carry over. 0002 sets it on the recreated table instead.
> I generated the attached reproducer with help from an LLM, and I
> confirm that your 0002 fixes the problem and Alexander's change on the
> [1] fails because of the reason you mentioned.
>
> Both patches LGTM.

Yes, I've tested both on my side -- no single run (of thousands) failed.
Also checked with LLM all the failures of 031_recovery_conflict registered
on wiki -- they all should be ruled out now.

Thank you for spending time on this!

Best regards,
Alexander