Re: Further cleanup related to statistics import support in postgres_fdw

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Subject: Re: Further cleanup related to statistics import support in postgres_fdw
Date: 2026-09-04 16:23:39
Message-ID: CAPmGK17P86A=HR2=r+YhUJYJ1h5o4zciK9qHuHOfKfM=jTWf3A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 4, 2026 at 11:25 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> This is expected behavior, because postgres_fdw determines whether the
> remote table is inherited or not, by checking only the table's
> relhassubclass. We could check pg_inherits as well, to detect false
> positives like this, but I didn't do so, because I don't think that
> that is worth complicating the code, as table inheritance is not that
> popular these days in the first place. Should we? I think another
> option would be to add a note about this behavior.

We are really nearing the end of the beta stabilization phase, I feel
like just adding the note like this:

"Note that if the remote table was inherited in the past, postgres_fdw
currently considers it inherited even if it is not currently
inherited. This restriction might be fixed in a future release."

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Alexander Lakhin 2026-09-04 16:00:00 Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl