| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Date: | 2017-06-12 07:49:18 |
| Message-ID: | a5df1cf6-dc51-1720-2abe-7957502b2cf9@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/06/09 20:47, Ashutosh Bapat wrote:
> Thanks for the long explanation. I guess, this should be written in
> comments somewhere in the code there. I see following comment in
> ATExecAttachPartition()
> --
> *
> * There is a case in which we cannot rely on just the result of the
> * proof.
> */
>
> --
>
> I guess, this comment should be expanded to explain what you wrote above.
Tried in the attached updated patch.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fixes-around-partition-constraint-handling-when-atta.patch | text/plain | 12.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-06-12 08:09:31 | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Previous Message | Michael Paquier | 2017-06-12 06:52:06 | Re: Why forcing Hot_standby_feedback to be enabled when creating a logical decoding slot on standby |