| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: A bug in mapping attributes in ATExecAttachPartition() |
| Date: | 2017-06-12 08:09:31 |
| Message-ID: | 043cbaff-c182-3f2e-8fc1-4dc164460763@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/06/09 20:49, Ashutosh Bapat wrote:
> May be we should pass a flag to predicate_implied_by() to handle NULL
> behaviour for CHECK constraints. Partitioning has shown that it needs
> to use predicate_implied_by() for comparing constraints and there may
> be other cases that can come up in future. Instead of handling it
> outside predicate_implied_by() we may want to change it under a flag.
IMHO, it may not be a good idea to modify predtest.c to suit the
partitioning code's needs. The workaround of checking that NOT NULL
constraints on partitioning columns exist seems to me to be simpler than
hacking predtest.c to teach it about the new behavior.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2017-06-12 08:29:44 | Re: PG10 Partitioned tables and relation_is_updatable() |
| Previous Message | Amit Langote | 2017-06-12 07:49:18 | Re: A bug in mapping attributes in ATExecAttachPartition() |