| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix CheckIndexCompatible comment |
| Date: | 2022-02-04 00:08:22 |
| Message-ID: | a0ad6f58-e8c9-45f4-a2b9-110753eaa6d1@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022/02/04 1:46, Yugo NAGATA wrote:
> Hello,
>
> I found a old parameter name 'heapRelation' in the comment
> of CheckIndexCompatible. This parameter was removed by 5f173040.
>
> Attached is a patch to remove it from the comment.
Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-02-04 00:14:53 | Re: Fix CheckIndexCompatible comment |
| Previous Message | David Rowley | 2022-02-04 00:07:42 | Re: Fix BUG #17335: Duplicate result rows in Gather node |