From: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Fix CheckIndexCompatible comment |
Date: | 2022-02-07 10:14:18 |
Message-ID: | 20220207191418.2bd9808dc875e9f4601380c2@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello, Fujii-san,
On Fri, 4 Feb 2022 09:08:22 +0900
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>
> On 2022/02/04 1:46, Yugo NAGATA wrote:
> > Hello,
> >
> > I found a old parameter name 'heapRelation' in the comment
> > of CheckIndexCompatible. This parameter was removed by 5f173040.
> >
> > Attached is a patch to remove it from the comment.
>
> Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"?
Agreed. I updated the patch to add a comment about 'oldId'.
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Attachment | Content-Type | Size |
---|---|---|
v2_fix_CheckIndexCompatible_comment.patch | text/x-diff | 638 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Frédéric Yhuel | 2022-02-07 10:26:07 | Allow parallel plan for referential integrity checks? |
Previous Message | Amit Kapila | 2022-02-07 10:08:50 | Re: row filtering for logical replication |