| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl> |
| Subject: | Re: GROUP BY DISTINCT |
| Date: | 2021-03-18 23:52:17 |
| Message-ID: | a0160421-654c-885e-1e90-5c21e9e1ab72@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
On 3/19/21 12:26 AM, Tom Lane wrote:
> I wrote:
>> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7.
>> I'll work on figuring that out.
>
> Actually, the problem is pretty obvious after comparing this use
> of foreach_delete_current() to every other one. I'm not sure why
> the compiler warnings are phrased just as they are, but the fix
> I just pushed does make 4.5 happy.
>
Thanks! Yeah, that looks obvious. Funny the older compilers noticed
this, not the new fancy ones.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Fearing | 2021-03-18 23:55:52 | Re: GROUP BY DISTINCT |
| Previous Message | Tom Lane | 2021-03-18 23:26:43 | Re: GROUP BY DISTINCT |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-03-18 23:54:53 | Re: Maintaining a list of pgindent commits for "git blame" to ignore |
| Previous Message | Tom Lane | 2021-03-18 23:40:36 | Re: Maintaining a list of pgindent commits for "git blame" to ignore |