Re: GROUP BY DISTINCT

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>
Subject: Re: GROUP BY DISTINCT
Date: 2021-03-18 23:26:43
Message-ID: 3858396.1616110003@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

I wrote:
> This is gcc 4.5, but hopefully whatever shuts it up will also work on 4.7.
> I'll work on figuring that out.

Actually, the problem is pretty obvious after comparing this use
of foreach_delete_current() to every other one. I'm not sure why
the compiler warnings are phrased just as they are, but the fix
I just pushed does make 4.5 happy.

regards, tom lane

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tomas Vondra 2021-03-18 23:52:17 Re: GROUP BY DISTINCT
Previous Message Tom Lane 2021-03-18 23:10:22 Re: GROUP BY DISTINCT

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-03-18 23:31:01 Re: Maintaining a list of pgindent commits for "git blame" to ignore
Previous Message Tom Lane 2021-03-18 23:10:22 Re: GROUP BY DISTINCT