| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |
| Date: | 2024-09-01 23:27:50 |
| Message-ID: | ZtT4dhlxuxdPPI8t@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Sep 01, 2024 at 10:35:27PM +0300, Alexander Korotkov wrote:
> This path hasn't changes since the patch revision when it was a
> utility command. I agree that this doesn't look like proper path for
> stored procedure. But I don't think src/backend/utils/adt is
> appropriate path either, because it's not really about data type.
> pg_wal_replay_wait() looks a good neighbor for
> pg_wal_replay_pause()/pg_wal_replay_resume() and other WAL-related
> functions. So, what about moving it to src/backend/access/transam?
Moving the new function to xlogfuncs.c while publishing
WaitForLSNReplay() makes sense to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-09-01 23:55:50 | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |
| Previous Message | Michael Paquier | 2024-09-01 23:19:23 | pgsql: Rename enum labels of PG_Locale_Strategy |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-09-01 23:44:49 | Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch |
| Previous Message | Peter Smith | 2024-09-01 22:49:37 | Re: Collect statistics about conflicts in logical replication |