| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |
| Date: | 2024-09-01 19:35:27 |
| Message-ID: | CAPpHfduQPYWATA2rfbYXsXM+Yspn1nQVwrEs=p303O428J57Yg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Aug 30, 2024 at 10:42 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 02.08.24 20:22, Alexander Korotkov wrote:
> > Implement pg_wal_replay_wait() stored procedure
>
> Why is this under src/backend/command/? Wouldn't it belong under
> src/backend/utils/adt/?
This path hasn't changes since the patch revision when it was a
utility command. I agree that this doesn't look like proper path for
stored procedure. But I don't think src/backend/utils/adt is
appropriate path either, because it's not really about data type.
pg_wal_replay_wait() looks a good neighbor for
pg_wal_replay_pause()/pg_wal_replay_resume() and other WAL-related
functions. So, what about moving it to src/backend/access/transam?
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-09-01 23:19:23 | pgsql: Rename enum labels of PG_Locale_Strategy |
| Previous Message | Thomas Munro | 2024-08-31 05:38:07 | pgsql: Fix unfairness in all-cached parallel seq scan. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-09-01 21:05:21 | Re: optimizing pg_upgrade's once-in-each-database steps |
| Previous Message | Tomas Vondra | 2024-09-01 19:30:27 | Re: scalability bottlenecks with (many) partitions (and more) |