| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-03-08 05:21:05 |
| Message-ID: | ZeqgQbe3ySMh-2NB@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote:
> On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
>> go away. That block is clearly marked as unreachable, so it doesn't
>> really serve a purpose.
>
> Thanks! Fixed as you suggested. Please see v3 patch.
Hmm. I am not sure if this one is a good idea. This makes the code a
bit more complicated to grasp under EEO_USE_COMPUTED_GOTO with the
reverse dispatch table, to say the least.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2024-03-08 05:22:52 | Re: Remove unnecessary code from psql's watch command |
| Previous Message | Amul Sul | 2024-03-08 05:13:57 | Re: Add system identifier to backup manifest |