| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-03-12 01:28:32 |
| Message-ID: | ME3P282MB31669EF949EE5EE93C45161CB62B2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 08 Mar 2024 at 13:21, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote:
>> On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>>> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
>>> go away. That block is clearly marked as unreachable, so it doesn't
>>> really serve a purpose.
>>
>> Thanks! Fixed as you suggested. Please see v3 patch.
>
> Hmm. I am not sure if this one is a good idea.
Sorry for the late reply!
> This makes the code a
> bit more complicated to grasp under EEO_USE_COMPUTED_GOTO with the
> reverse dispatch table, to say the least.
I'm not get your mind. Could you explain in more detail?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-03-12 01:34:36 | Re: Popcount optimization using AVX512 |
| Previous Message | Michael Paquier | 2024-03-12 01:22:18 | Re: Using the %m printf format more |