Re: Typo in "43.9.1. Reporting Errors and Messages"?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Euler Taveira <euler(at)eulerto(dot)com>, eric(dot)mutta(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Typo in "43.9.1. Reporting Errors and Messages"?
Date: 2023-11-01 00:18:47
Message-ID: ZUGZZ-J_AeeWM4_o@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Tue, Oct 31, 2023 at 09:00:00PM +0300, Alexander Lakhin wrote:
> I don't remember details, but I think the primary reason for the change
> was that "RAISE_EXCEPTION" occurred in the whole tree only once (before
> 66bde49d96). Now I see, that I had chosen the wrong replacement — I agree
> with Euler, change to "raise_exception" would be more appropriate.

Indeed, it looks like the origin of the confusion is the casing here,
so changing to "raise_exception" like in the appendix sounds good to
me:
https://www.postgresql.org/docs/devel/errcodes-appendix.html

So you mean something like the attached then?

> (I've found a similar mention of ERRCODE_xxx in btree.sgml:
>   Before doing so, the function should check the sign
>   of <replaceable>offset</replaceable>: if it is less than zero, raise
>   error <literal>ERRCODE_INVALID_PRECEDING_OR_FOLLOWING_SIZE</literal> (22013)
>   with error text like <quote>invalid preceding or following size in window
>   function</quote>.
> but I think that's okay here, because that identifier supposed to be used
> as-is in ereport/elog.)

Yep, still this one is not that old (0a459cec96d3).
--
Michael

Attachment Content-Type Size
plpg-errcode-doc.patch text/x-diff 670 bytes

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2023-11-01 17:09:59 Re: Document target_role param of ALTER DEFAULT PRIVILEGES
Previous Message Alexander Lakhin 2023-10-31 18:00:00 Re: Typo in "43.9.1. Reporting Errors and Messages"?

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-11-01 00:29:43 Re: [PATCH] postgresql.conf.sample comment alignment.
Previous Message shihao zhong 2023-11-01 00:13:39 EXCLUDE COLLATE in CREATE/ALTER TABLE document