Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Ryoga Yoshida <bt23yoshidar(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z
Date: 2023-09-21 05:59:25
Message-ID: ZQvbvSygEe3aLUev@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 21, 2023 at 05:50:26PM +1200, David Rowley wrote:
> I've pushed your patch plus some additional code to escape the text
> specified in --buffer-usage-limit before passing it to the server in
> commit 5cfba1ad6

That was fast. If I may ask, why don't you have some regression tests
for the two code paths of vacuumdb that append this option to the
commands generated for VACUUM and ANALYZE?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-21 06:07:39 Re: pg_upgrade and logical replication
Previous Message Michael Paquier 2023-09-21 05:57:43 Re: pg_upgrade and logical replication