| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Ryoga Yoshida <bt23yoshidar(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z |
| Date: | 2023-09-22 05:21:46 |
| Message-ID: | ZQ0kanW9OGJYymWs@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 21, 2023 at 06:56:29PM +1200, David Rowley wrote:
> I deem it pretty unlikely that someone will accidentally remove the
> code that I just committed and a test to test that vacuumdb -Z
> --buffer-usage-limit ... passes the BUFFER_USAGE_LIMIT option would
> likely just forever mark that we once had a trivial bug that forgot to
> include the --buffer-usage-limit when -Z was specified.
Perhaps so.
> If others feel strongly that a test is worthwhile, then I'll reconsider.
I don't know if you would like that, but the addition is as simple as
the attached, FYI.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| vacuumdb-tests.patch | text/x-diff | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-09-22 05:26:56 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Tatsuo Ishii | 2023-09-22 05:16:40 | Re: Row pattern recognition |