Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view
Date: 2023-09-01 10:44:24
Message-ID: ZPHAiNp+yKMsa/vc@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 01, 2023 at 11:32:35AM +0200, Jim Jones wrote:
> Would you be in favor of parsing #comments instead? Given that # is
> currently already being parsed (ignored), it shouldn't add too much
> complexity to the code.

I am not sure what you have in mind, but IMO any solution would live
better as long as a solution is:
- not linked to hba.c, handled in a separate code path.
- linked to all configuration files where comments are supported, if
need be.

Perhaps others have more opinions.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2023-09-01 10:50:08 Re: SQL:2011 application time
Previous Message Jim Jones 2023-09-01 10:40:22 Re: PATCH: Add REINDEX tag to event triggers