| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Ignore 2PC transaction GIDs in query jumbling |
| Date: | 2023-08-13 06:25:33 |
| Message-ID: | ZNh3XV2+cubcVaWk@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 01, 2023 at 10:46:58AM +0800, Julien Rouhaud wrote:
> On Tue, Aug 01, 2023 at 11:37:49AM +0900, Michael Paquier wrote:
>> On Tue, Aug 01, 2023 at 10:22:09AM +0800, Julien Rouhaud wrote:
>>> Looking at the rest of the ignored patterns, the only remaining one would be
>>> DEALLOCATE, which AFAICS doesn't have a query_jumble_ignore tag for now.
>>
>> This one seems to be simple as well with a location field, looking
>> quickly at its Node.
>
> Agreed, it should be as trivial to implement as for the 2pc commands :)
Perhaps not as much, actually, because I was just reminded that
DEALLOCATE is something that pg_stat_statements ignores. So this
makes harder the introduction of tests. Anyway, I guess that your own
extension modules have a need for a query ID compiled with these
fields ignored?
For now, I have applied the 2PC bits independently, as of 638d42a.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2023-08-13 06:48:22 | Re: Ignore 2PC transaction GIDs in query jumbling |
| Previous Message | Noah Misch | 2023-08-13 03:15:31 | pg_waldump vs. all-zeros WAL files; server creation of such files |