Re: pg_upgrade fails with in-place tablespace

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Rui Zhao <xiyuan(dot)zr(at)alibaba-inc(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade fails with in-place tablespace
Date: 2023-08-09 04:53:23
Message-ID: ZNMbwyByFIb6E4x3@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 09, 2023 at 11:47:58AM +0800, Rui Zhao wrote:
> I believe that utilizing appendPQExpBufferStr(buf, "''"); would be better and more meaningful than using appendStringLiteralConn(buf, "", conn); in this scenario.
> I apologize for this wrong usage. Please help me fix it.
> I will try to respond to pg_upgrade after my deep dive.

That was my original suggestion in [1], and what you've added gives
exactly the same result.

[1]: https://www.postgresql.org/message-id/ZNGhF6iBpUKgNimI%40paquier.xyz
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2023-08-09 04:59:21 Re: pgbench: allow to exit immediately when any client is aborted
Previous Message Amit Kapila 2023-08-09 04:44:05 Re: Handle infinite recursion in logical replication setup