Re: PATCH: Add REINDEX tag to event triggers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Garrett Thornburg <film42(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PATCH: Add REINDEX tag to event triggers
Date: 2023-07-25 23:50:56
Message-ID: ZMBf4HKm+mrHgSM5@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 25, 2023 at 04:34:47PM +0800, jian he wrote:
> so T_ReindexStmt should only be in ProcessUtilitySlow, if you want
> to create an event trigger on reindex?
>
> regression tests work fine. I even play with partitions.

It would be an idea to have some regression tests for partitions,
actually, so as some patterns around ReindexMultipleInternal() are
checked. We could have a REINDEX DATABASE in a TAP test with an event
trigger, as well, but I don't feel strongly about the need to do that
much extra work in 090_reindexdb.pl or 091_reindexdb_all.pl if
partitions cover the multi-table case.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-07-26 00:02:54 Re: Support worker_spi to execute the function dynamically.
Previous Message Peter Geoghegan 2023-07-25 23:47:41 Re: POC, WIP: OR-clause support for indexes