Re: Another incorrect comment for pg_stat_statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Another incorrect comment for pg_stat_statements
Date: 2023-06-28 07:04:48
Message-ID: ZJvbkLdx5cqXBJGl@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> - /* Remove the key if it exists, starting with the top-level entry */
> + /* Remove the key if it exists, starting with the non-top-level entry */
> key.toplevel = false;
> entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
> if (entry) /* found */

Nice catch. That's indeed wrong. Will fix.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2023-06-28 07:09:55 Re: Another incorrect comment for pg_stat_statements
Previous Message Richard Guo 2023-06-28 06:51:54 Re: Assert !bms_overlap(joinrel->relids, required_outer)