| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow pg_archivecleanup to remove backup history files |
| Date: | 2023-06-12 07:33:27 |
| Message-ID: | ZIbKR7EiMXG3ucFG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 09, 2023 at 12:32:15AM +0900, Fujii Masao wrote:
> + <para>
> + Remove backup history files.
>
> Isn't it better to document clearly which backup history files to be removed? For example, "In addition to removing WAL files, remove backup history files with prefixes logically preceding the oldestkeptwalfile.".
I've written about this part at the beginning of this one, where this
sounds like a duplicated description of the Description section:
https://www.postgresql.org/message-id/ZG1nq13v411y4TFL@paquier.xyz
> printf(_(" -n, --dry-run dry run, show the names of the files that would be removed\n"));
> + printf(_(" -b, --clean-backup-history clean up files including backup history files\n"));
>
> Shouldn't -b option be placed in alphabetical order?
+1.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-06-12 08:20:14 | Re: Remove WindowClause PARTITION BY items belonging to redundant pathkeys |
| Previous Message | torikoshia | 2023-06-12 04:07:34 | Re: RFC: Logging plan of the running query |