| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow pg_archivecleanup to remove backup history files |
| Date: | 2023-06-08 15:32:15 |
| Message-ID: | 0e962f8a-78f5-eafe-1d54-7434482e9fd1@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023/05/31 10:51, torikoshia wrote:
> Update the patch according to the advice.
Thanks for updating the patches! I have small comments regarding 0002 patch.
+ <para>
+ Remove backup history files.
Isn't it better to document clearly which backup history files to be removed? For example, "In addition to removing WAL files, remove backup history files with prefixes logically preceding the oldestkeptwalfile.".
printf(_(" -n, --dry-run dry run, show the names of the files that would be removed\n"));
+ printf(_(" -b, --clean-backup-history clean up files including backup history files\n"));
Shouldn't -b option be placed in alphabetical order?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-06-08 15:40:12 | index prefetching |
| Previous Message | Josef Šimánek | 2023-06-08 15:23:36 | Re: GTIN14 support for contrib/isn |