| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | gkokolatos(at)pm(dot)me |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-05-10 02:22:10 |
| Message-ID: | ZFr/0s5MTb5S7r7u@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 09, 2023 at 02:12:44PM +0000, gkokolatos(at)pm(dot)me wrote:
> Thank you both for looking. A small consolation is that now there are
> tests for this case.
+1, noticing that was pure luck ;)
Worth noting that the patch posted in [1] has these tests, not the
version posted in [2].
+ create_sql => 'INSERT INTO dump_test.test_compression_method (col1) '
+ . 'SELECT string_agg(a::text, \'\') FROM generate_series(1,4096) a;',
Yep, good and cheap idea to check for longer chunks. That should be
enough to loop twice.
[1]: https://www.postgresql.org/message-id/SYTRcNgtAbzyn3y3IInh1x-UfNTKMNpnFvI3mr6SyqyVf3PkaDsMy_cpKKgsl3_HdLy2MFAH4zwjxDmFfiLO8rWtSiJWBtqT06OMjeNo4GA=@pm.me
[2]: https://www.postgresql.org/message-id/f735df01-0bb4-2fbc-1297-73a520cfc534@enterprisedb.com
> Moving on to the other open item for this, please find attached v2
> of the patch as requested.
Did you notice the comments of [3] about the second patch that aims to
add the null termination in the line from the LZ4 fgets() callback?
[3]: https://www.postgresql.org/message-id/ZFhCyn4Gm2eu60rB@paquier.xyz
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tender wang | 2023-05-10 02:57:46 | Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog |
| Previous Message | Justin Pryzby | 2023-05-10 00:37:27 | Re: fix stats_fetch_consistency value in postgresql.conf.sample |