Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog

From: tender wang <tndrwang(at)gmail(dot)com>
To: Xiaoran Wang <wxiaoran(at)vmware(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog
Date: 2023-05-10 02:57:46
Message-ID: CAHewXNkhCBfit7ufCSaRPkqcUDhO-6W5RNyQdwooqE72v3mJtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Xiaoran Wang <wxiaoran(at)vmware(dot)com> 于2023年3月18日周六 15:04写道：

> Hi hackers,
>
> In heap_create_with_catalog, the Relation new_rel_desc is created
> by RelationBuildLocalRelation, not table_open. So it's better to
> call RelationClose to release it.
>
Why it's better to call RelationClose? Is there a problem if using
table_close()?

> What's more, the comment for it seems useless, just delete it.
>
> Thanks!
>

regard, tender wang

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-05-10 03:11:20 Unlinking Parallel Hash Join inner batch files sooner
Previous Message Michael Paquier 2023-05-10 02:22:10 Re: Add LZ4 compression in pg_dump