| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | gkokolatos(at)pm(dot)me |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-05-06 02:51:19 |
| Message-ID: | ZFXAp30HxBH2e4+Q@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 05, 2023 at 02:13:28PM +0000, gkokolatos(at)pm(dot)me wrote:
> Good point. I thought about it before submitting the patch. I
> concluded that given the complexity and operations involved in
> LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore
> code, the memset() call will be negligible. However from the
> readability point of view, the function is a bit cleaner with the
> memset().
>
> I will not object to any suggestion though, as this is a very
> trivial point. Please find attached a v2 of the patch following the
> suggested approach.
Please note that an open item has been added for this stuff.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-05-06 02:58:43 | Re: Tab completion for CREATE SCHEMAAUTHORIZATION |
| Previous Message | Tom Lane | 2023-05-06 02:49:15 | Re: MERGE lacks ruleutils.c decompiling support!? |