| From: | gkokolatos(at)pm(dot)me |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | andrew(at)dunslane(dot)net, exclusion(at)gmail(dot)com, tomas(dot)vondra(at)enterprisedb(dot)com, pryzby(at)telsasoft(dot)com, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, rachelmheaton(at)gmail(dot)com |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-05-07 15:01:52 |
| Message-ID: | Y15gcrC3SU2y5u63cE3p9APTZ-s6aOoeIu1MX29nVycUpq0l7dss7chpw1P7jdB5Nrs49KwabqdlW1Q50ApVd9GuxLUtFsI-MmQq7ZCY-H8=@pm.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 6, 2023 at 04:51, Michael Paquier <[michael(at)paquier(dot)xyz](mailto:On Sat, May 6, 2023 at 04:51, Michael Paquier <<a href=)> wrote:
> On Fri, May 05, 2023 at 02:13:28PM +0000, gkokolatos(at)pm(dot)me wrote:
>> Good point. I thought about it before submitting the patch. I
>> concluded that given the complexity and operations involved in
>> LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore
>> code, the memset() call will be negligible. However from the
>> readability point of view, the function is a bit cleaner with the
>> memset().
>>
>> I will not object to any suggestion though, as this is a very
>> trivial point. Please find attached a v2 of the patch following the
>> suggested approach.
>
> Please note that an open item has been added for this stuff.
Thank you but I am not certain I know what that means. Can you please explain?
Cheers,
//Georgios
> --
> Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-05-07 15:02:33 | Re: MERGE lacks ruleutils.c decompiling support!? |
| Previous Message | Tomas Vondra | 2023-05-07 12:50:51 | Re: Missing update of all_hasnulls in BRIN opclasses |