Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable()
Date: 2023-03-04 02:30:34
Message-ID: ZAKtSjTW06jAEAVK@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 03, 2023 at 04:33:39PM -0800, Nathan Bossart wrote:
> Given both Bharath and I missed this, perhaps we should add a comment about
> this behavior.

Makes sense to me to document that in a better way. What about the
addition of a short paragraph at the top of XLogFileReadAnyTLI() that
explains the behaviors we expect depending on the values of
XLogSource? The case of XLOG_FROM_ANY with the order to scan the
archives then pg_wal/ for each timeline is the most important bit,
surely.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-03-04 02:35:30 Re: [PoC] Let libpq reject unexpected authentication requests
Previous Message Thomas Munro 2023-03-04 01:23:10 Re: RADIUS tests and improvements