| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable() |
| Date: | 2023-03-04 02:44:56 |
| Message-ID: | CALj2ACXAZOgBkEUv_iJNECuUAh+WoA9K44p32VLhenoy-PeV8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 4, 2023 at 8:00 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Mar 03, 2023 at 04:33:39PM -0800, Nathan Bossart wrote:
> > Given both Bharath and I missed this, perhaps we should add a comment about
> > this behavior.
>
> Makes sense to me to document that in a better way. What about the
> addition of a short paragraph at the top of XLogFileReadAnyTLI() that
> explains the behaviors we expect depending on the values of
> XLogSource? The case of XLOG_FROM_ANY with the order to scan the
> archives then pg_wal/ for each timeline is the most important bit,
> surely.
+1. I will send a patch in a bit.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-03-04 04:17:05 | Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable() |
| Previous Message | Michael Paquier | 2023-03-04 02:35:30 | Re: [PoC] Let libpq reject unexpected authentication requests |