Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
Date: 2022-09-28 01:23:11
Message-ID: YzOhsIr4RZllbKv6@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 27, 2022 at 01:38:26AM +0000, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> Maybe you mentioned about sigint_interrupt_enabled,
> and it also seems to be modified in the signal handler.

Yeah, at least as of the cancel callback psql_cancel_callback() that
handle_sigint() would call on SIGINT as this is set by psql. So it
does not seem right to use a boolean rather than a sig_atomic_t in
this case, as well.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bagga, Rishu 2022-09-28 01:57:34 Re: SLRUs in the main buffer pool - Page Header definitions
Previous Message Masahiko Sawada 2022-09-28 01:13:59 Re: [PATCH] Log details for client certificate failures