| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Joe Conway <mail(at)joeconway(dot)com> |
| Subject: | Re: use has_privs_of_role() for pg_hba.conf |
| Date: | 2022-10-06 08:09:42 |
| Message-ID: | Yz6NRrfd7n2AXoHh@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 04, 2022 at 07:25:51AM -0700, Nathan Bossart wrote:
> On Mon, Apr 04, 2022 at 09:36:13AM -0400, Joshua Brindle wrote:
>> Good catch, I think this is a logical followup to the previous
>> has_privs_of_role patch.
>>
>> Reviewed and +1
>
> Thanks! I created a commitfest entry for this:
This patch looks simple, but it is a very sensitive area so I think
that we should be really careful. pg_hba.conf does not have a lot of
test coverage, so I'd really prefer if we add something to see the
difference of behavior and check the behavior that we are switching
here. What I have just committed in 051b096 would help a bit here,
actually, and changing pg_hba.conf rules with rule reload is cheap.
Joe, you are registered as a reviewer and committer of this patch, by
the way. Are you planning to look at it?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kato-sho@fujitsu.com | 2022-10-06 08:12:37 | fix comment typo in xlogprefetcher.c |
| Previous Message | Masahiko Sawada | 2022-10-06 08:06:30 | Re: Perform streaming logical transactions by background workers and parallel apply |