From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: use has_privs_of_role() for pg_hba.conf |
Date: | 2022-10-06 11:33:46 |
Message-ID: | 491dba16-55df-d5fd-1ae7-01b5140987f0@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10/6/22 04:09, Michael Paquier wrote:
> On Mon, Apr 04, 2022 at 07:25:51AM -0700, Nathan Bossart wrote:
>> On Mon, Apr 04, 2022 at 09:36:13AM -0400, Joshua Brindle wrote:
>>> Good catch, I think this is a logical followup to the previous
>>> has_privs_of_role patch.
>>>
>>> Reviewed and +1
>>
>> Thanks! I created a commitfest entry for this:
>
> This patch looks simple, but it is a very sensitive area so I think
> that we should be really careful. pg_hba.conf does not have a lot of
> test coverage, so I'd really prefer if we add something to see the
> difference of behavior and check the behavior that we are switching
> here.
Agreed
> Joe, you are registered as a reviewer and committer of this patch, by
> the way. Are you planning to look at it?
I am meaning to get to it, but as you say wanted to spend some time to
understand the nuances and life keeps getting in the way. I will try to
prioritize it over the next week.
Joe
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-10-06 11:37:53 | Re: Perform streaming logical transactions by background workers and parallel apply |
Previous Message | Michael Paquier | 2022-10-06 11:26:55 | Re: fix comment typo in xlogprefetcher.c |