Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: nathandbossart(at)gmail(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, andres(at)anarazel(dot)de, cary(dot)huang(at)highgo(dot)ca, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
Date: 2022-08-24 04:34:54
Message-ID: YwWqbjN1IHaBlQOb@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 24, 2022 at 10:48:01AM +0900, Kyotaro Horiguchi wrote:
> By the way, I think we use INSTR_TIME_* macros to do masure internal
> durations (mainly for the monotonic clock characteristics, and to
> reduce performance degradation on Windows?). I'm not sure that's
> crutial here but I don't think there's any reason to use
> GetCurrentTimestamp() instead.

This implies two calls of gettimeofday(), but that does not worry me
much in this code path. There is some consistency with
CheckpointGuts() where we take timestamps for the sync requests.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-08-24 04:38:44 Re: ICU for global collation
Previous Message Tom Lane 2022-08-24 04:32:53 Re: ecpg assertion on windows