| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | nathandbossart(at)gmail(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, andres(at)anarazel(dot)de, cary(dot)huang(at)highgo(dot)ca, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
| Date: | 2022-08-25 08:25:49 |
| Message-ID: | 20220825.172549.166793275631762683.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 24 Aug 2022 13:34:54 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Wed, Aug 24, 2022 at 10:48:01AM +0900, Kyotaro Horiguchi wrote:
> > By the way, I think we use INSTR_TIME_* macros to do masure internal
> > durations (mainly for the monotonic clock characteristics, and to
> > reduce performance degradation on Windows?). I'm not sure that's
> > crutial here but I don't think there's any reason to use
> > GetCurrentTimestamp() instead.
>
> This implies two calls of gettimeofday(), but that does not worry me
> much in this code path. There is some consistency with
> CheckpointGuts() where we take timestamps for the sync requests.
Mmm. heap_vacuum_rel does the same. From the other direction, the two
are the only use of GetCurrentTimestamp() for this purpose. However,
I'm fine with that. Thanks for the info.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kukushkin | 2022-08-25 08:34:40 | Re: pg_rewind WAL segments deletion pitfall |
| Previous Message | Dong Wook Lee | 2022-08-25 07:52:04 | Re: pg_basebackup: add test about zstd compress option |