| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: plpgsql-trigger.html: Format TG_ variables as table (patch) |
| Date: | 2022-08-31 12:18:26 |
| Message-ID: | Yw9Rkn0UXvsIhACV@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Re: Daniel Gustafsson
> This, and the other string variables, now reads a bit strange IMO:
>
> - Data type <type>text</type>; a string of
> + string
> <literal>INSERT</literal>, <literal>UPDATE</literal>,
> <literal>DELETE</literal>, or <literal>TRUNCATE</literal>
>
> Wouldn't it be better with "string containing <literal>INSERT.." or something
> similar?
Right, that felt strange to me as well, but I couldn't think of
something better.
"string containing" is again pretty boilerplatish, how about just
"contains"?
Christoph
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-plpgsql-trigger.html-Use-more-concise-wording-for-TG.patch | text/x-diff | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-08-31 12:30:07 | Re: replacing role-level NOINHERIT with a grant-level option |
| Previous Message | Daniel Gustafsson | 2022-08-31 12:12:06 | Re: plpgsql-trigger.html: Format TG_ variables as table (patch) |