Re: plpgsql-trigger.html: Format TG_ variables as table (patch)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Date: 2022-08-31 12:12:06
Message-ID: AF7104E5-8B27-4C84-8771-63972396E957@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 31 Aug 2022, at 13:55, Christoph Berg <myon(at)debian(dot)org> wrote:
>
> Re: To Peter Eisentraut
>> The new version of the patch just moves up the data types, and removes
>> the extra clutter from the beginnings of each description:
>
> The last version had the brackets in TG_ARGV[] (text[]) duplicated.

This, and the other string variables, now reads a bit strange IMO:

- Data type <type>text</type>; a string of
+ string
<literal>INSERT</literal>, <literal>UPDATE</literal>,
<literal>DELETE</literal>, or <literal>TRUNCATE</literal>

Wouldn't it be better with "string containing <literal>INSERT.." or something
similar?

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2022-08-31 12:18:26 Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Previous Message Daniel Gustafsson 2022-08-31 12:09:06 pg_upgrade generated files in subdir follow-up