Re: Materialized view rewrite is broken when there is an event trigger

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Önder Kalacı <onderkalaci(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Materialized view rewrite is broken when there is an event trigger
Date: 2022-08-09 13:13:21
Message-ID: YvJdcZcSb1Emlaat@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 09, 2022 at 02:55:06PM +0200, Önder Kalacı wrote:
> Attached a patch to fix as well. If the patch looks good to you, can you
> consider getting this to PG 15?

Thanks, this one is on me so I have added an open item. I will
unfortunately not be able to address that this week because of life,
but I should be able to grab a little bit of time next week to look at
what you have.

Please note that we should not add an event in create_am.sql even if
it is empty, as it gets run in parallel of other tests so there could
be interferences. I think that this had better live in
sql/event_trigger.sql, even if it requires an extra table AM to check
this specific case.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-08-09 13:16:34 Re: automatically generating node support functions
Previous Message Önder Kalacı 2022-08-09 12:55:06 Materialized view rewrite is broken when there is an event trigger