| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jacob Champion <jchampion(at)timescale(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Commitfest Update |
| Date: | 2022-07-16 02:59:00 |
| Message-ID: | YtIpdPCSJ8gv1BJn@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 15, 2022 at 05:23:48PM -0700, Jacob Champion wrote:
> I agree in principle -- I think, ideally, WoA patches should be
> procedurally closed at the end of a commitfest, and carried forward when
> the author has actually responded. The problems I can imagine resulting
> from this are
>
> - Some reviewers mark WoA _immediately_ upon sending an email. I think
> authors should have a small grace period to respond before having their
> patches automatically "muted" by the system, if the review happens right
> at the end of the CF.
On this point, I'd like to think that a window of two weeks is a right
balance. That's half of the commit fest, so that leaves plenty of
time for one to answer. There is always the case where one is on
vacations for a period longer than that, but it is also possible for
an author to add a new entry in a future CF for the same patch. If I
recall correctly, it should be possible to move a patch that has been
closed even if the past CF has been marked as been concluded, allowing
one to keep the same patch with its history and annotations.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Kwan | 2022-07-16 03:16:27 | Re: Making pg_rewind faster |
| Previous Message | Zhihong Yu | 2022-07-16 02:49:23 | Freeing sortgroupatts in use_physical_tlist |