Re: Making pg_rewind faster

From: Justin Kwan <justinpkwan(at)outlook(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: vignesh <vignesh(at)cloudflare(dot)com>, "jkwan(at)cloudflare(dot)com" <jkwan(at)cloudflare(dot)com>, vignesh ravichandran <admin(at)viggy28(dot)dev>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>
Subject: Re: Making pg_rewind faster
Date: 2022-07-16 03:16:27
Message-ID: DM6PR03MB45700F072AC8BC07F58E8E21A08A9@DM6PR03MB4570.namprd03.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi everyone!

I've also attached the pg_rewind optimization patch file for Postgres version 14.4. The previous patch file targets version Postgres version 15 Beta 1/2.

Thanks,
Justin
________________________________
From: Justin Kwan <jkwan(at)cloudflare(dot)com>
Sent: July 15, 2022 6:13 PM
To: vignesh ravichandran <admin(at)viggy28(dot)dev>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>; vignesh <vignesh(at)cloudflare(dot)com>; justinpkwan(at)outlook(dot)com <justinpkwan(at)outlook(dot)com>
Subject: Re: Making pg_rewind faster

Looping in my other email.

On Thu, Jun 30, 2022 at 6:22 AM vignesh ravichandran <admin(at)viggy28(dot)dev<mailto:admin(at)viggy28(dot)dev>> wrote:
Hi Hackers,

I have been using pg_rewind in production for 2 years. One of the things that I noticed in pg_rewind is if it doesn't know what to do with a file "it copies". I understand it's the more safer option. After all, the alternative, pg_basebackup copies all the files from source to target.

However, this is making pg_rewind inefficient when we have a high number of WAL files. Majority of the data (in most of my cases 95%+) that it copies are WAL files which are anyway same between the source and target. Skipping those same WAL files from copying will improve the speed of pg_rewind a lot.

1. Does pg_rewind need to copy WAL files before the WAL that contains the last common check point?

Heikki's presentation https://pgsessions.com/assets/archives/pg_rewind-presentation-paris.pdf gave me a good overview and also explained the behavior what I mentioned.

Thanks,
Vignesh

Attachment Content-Type Size
v1-pg14.4-0001-Avoid-copying-WAL-segments-before-divergence-to-spee.patch application/octet-stream 13.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-16 03:32:54 Re: Freeing sortgroupatts in use_physical_tlist
Previous Message Michael Paquier 2022-07-16 02:59:00 Re: Commitfest Update